Change Most Nodejs Strings to use Generated Resource Helper#1382
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Oct 21, 2016
Merged
Conversation
**Bug** We currently go through a `SR` class for accessing localizable strings. This is a pain because when you add a new string, you also have to update the `SR` class. Additionally, it is very easy for the string keys to get out of sync with the resource file. **Fix** For the main Node.js project, change basic string use cases to use the `Resources` file directly instead
mjbvz
commented
Oct 21, 2016
| internal const string NpmCancelled = "NpmCancelled"; | ||
| internal const string NpmCancelledWithErrors = "NpmCancelledWithErrors"; | ||
| internal const string NpmCompletedWithErrors = "NpmCompletedWithErrors"; | ||
| internal const string NpmNodePackageInstallation = "NpmNodePackageInstallation"; |
Contributor
Author
There was a problem hiding this comment.
I'll handle all of these strings in the next pass. They are used inside attributes, such as SRDescriptionAttribute, and therefore must be constant strings. The generated resource properties are not constant so a slightly different approach is required here.
mjbvz
added a commit
to mjbvz/nodejstools
that referenced
this pull request
Oct 21, 2016
**Bug** Follow up on microsoft#1382. That PR changed most strings used in code to use the generated resource helper classes. It did not convert over strings that are used in attributes. **Fix** Move these strings over as well. The strings passed to attributes must be constant, so `nameof` is used to ensure the strings are strongly typed.
mjbvz
added a commit
to mjbvz/nodejstools
that referenced
this pull request
Oct 21, 2016
**Bug** Follow up on microsoft#1382. That PR changed most strings used in code to use the generated resource helper classes. It did not convert over strings that are used in attributes. **Fix** Move these strings over as well. The strings passed to attributes must be constant, so `nameof` is used to ensure the strings are strongly typed.
mjbvz
added a commit
that referenced
this pull request
Oct 24, 2016
…1384) **Bug** Follow up on #1382. That PR changed most strings used in code to use the generated resource helper classes. It did not convert over strings that are used in attributes. **Fix** Move these strings over as well. The strings passed to attributes must be constant, so `nameof` is used to ensure the strings are strongly typed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
We currently go through a
SRclass for accessing localizable strings. This is a pain because when you add a new string, you also have to update theSRclass. Additionally, it is very easy for the string keys to get out of sync with the resource file.Fix
For the main Node.js project, change basic string use cases to use generated
Resourcesfile directly instead. Now you only have to update a single file to add a new string.This change was previously made with #729, but that was never merged. Now that we are actually localizing, the current
SRapproach is a major burden.